Messages in this thread | | | Date | Wed, 16 Jul 2014 19:35:21 +1000 | From | Stuart Longland <> | Subject | Re: [PATCH] drivers/rtc/rtc-isl12022.c: Device tree support |
| |
Hi Mark, On 16/07/14 18:59, Mark Rutland wrote: > On Wed, Jul 16, 2014 at 03:28:25AM +0100, Stuart Longland wrote: >> Add some support for configuring isl12020/isl12022 devices using the >> Device Tree blob. >> >> Signed-off-by: Stuart Longland <stuartl@vrt.com.au> > > Please document this as with isl,isl12057, in > Documentation/devicetree/bindings/i2c/trivial-devices.txt > > The string itself looks fine.
No problems. I'll do this shortly.
>> +#ifdef CONFIG_OF >> + .of_match_table = of_match_ptr(isl12022_dt_match), >> +#endif > > You can drop the ifdef here, of_match_ptr(x) is NULL if !CONFIG_OF.
Ahh okay, I wasn't sure how of_match_ptr worked, so I thought I'd play it safe. A revised patch is coming right up.
Regards, -- Stuart Longland Systems Engineer _ ___ \ /|_) | T: +61 7 3535 9619 \/ | \ | 38b Douglas Street F: +61 7 3535 9699 SYSTEMS Milton QLD 4064 http://www.vrt.com.au
| |