Messages in this thread | | | From | Pranith Kumar <> | Date | Wed, 16 Jul 2014 00:35:43 -0400 | Subject | Re: [PATCH 1/1] scripts/get_maintainer: increase threshold for --follow to reduce time |
| |
On Wed, Jul 16, 2014 at 12:08 AM, Joe Perches <joe@perches.com> wrote: > On Tue, 2014-07-15 at 22:23 -0400, Pranith Kumar wrote: >> ping? >> >> On Sat, Jul 12, 2014 at 3:25 PM, Pranith Kumar <bobby.prani@gmail.com> wrote: >> > get_maintainer tries to follow files with a matching threshold of default 50%. >> > This is not really necessary as we do not change a file and move it in the same >> > commit usually. Increasing the threshold to 90% should be sufficient. <snip> > While I understand the goal, I wonder if this should > be in a .gitconfig, not in get_maintainers at all. > > (git doesn't seem to have a config entry for score though) > > If not, the % should probably be cmd-line configurable. > >
The problem is with the default which is at 50% now. That means that a commit needs to have changed a file by more than 50% -and- moved it in the same commit. This is highly discouraged and unlikely to happen in our case.
Even if we have this a cmd-line configuration, setting the default to 90% really makes sense, no?
-- Pranith
| |