lkml.org 
[lkml]   [2014]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4] hwmon: pwm-fan: Add pwm-fan driver
Hi Kamil,

On 07/16/2014 03:33 PM, Kamil Debski wrote:
> The pwm-fan driver enables control of fans connected to PWM lines.
> This driver uses the PWM framework, so it is compatible with all
> PWM devices that provide drivers through the PWM framework.
>
> Signed-off-by: Kamil Debski <k.debski@samsung.com>
> ---
> Changes since v3:
> - fix missing "\n" in error messages
> - remove of_match_ptr which was not necessary
> - change error returned in case of failed allocation to -ENOMEM
> Changes since v2:
> - add CONFIG_PM_SLEEP around pwm_fan_suspend and pwm_fan_resume
> Changes since v1:
> - added documentation to Documentation/hwmon
> - fix checkpatch errors
> - added extra description to Kconfig
> - removed whitespace errors
> - include files rearranged to be in alphabetical order
> - remove unused sysfs entry pwm1_enable
> - changed the behavior of the set_pwm function
> - when 0 PWM value is set pwm_disable is run
> - pwm_config return value is checked for errors
> - use of ATTRIBUTE_GROUPS was added
> - removed "Not enouch memory" error message
> - fixed probe return value in case of devm_of_pwm_get error
> - changed hwmon_device_register_with_groups to
> devm_hwmon_device_register_with_groups
> - changes suspend/resume to use pwm_disable/enable
> - removed unnecessary CONFIG_PM_SLEEP ifdefs
> ---
> .../devicetree/bindings/hwmon/pwm-fan.txt | 12 ++
> Documentation/hwmon/pwm-fan | 17 ++
> drivers/hwmon/Kconfig | 11 ++
> drivers/hwmon/Makefile | 1 +
> drivers/hwmon/pwm-fan.c | 202 ++++++++++++++++++++
> 5 files changed, 243 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/pwm-fan.txt
> create mode 100644 Documentation/hwmon/pwm-fan
> create mode 100644 drivers/hwmon/pwm-fan.c

This version addressed all of my comments.. Thanks :-)

Reviewed-by: Varka Bhadram <varkabhadram@gmail.com>

--
Regards,
Varka Bhadram.



\
 
 \ /
  Last update: 2014-07-20 01:21    [W:0.047 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site