Messages in this thread | | | Date | Wed, 16 Jul 2014 12:42:46 -0700 | From | Saravana Kannan <> | Subject | Re: [PATCH v3 1/2] cpufreq: Don't destroy/realloc policy/sysfs on hotplug/suspend |
| |
On 07/16/2014 08:28 AM, Viresh Kumar wrote: > On 16 July 2014 19:59, Dirk Brandewie <dirk.brandewie@gmail.com> wrote: >> stop_cpu() only needs to be called during __cpufreq_remove_dev_prepare() no >> where else. > > Oh, thanks for reminding us.. > > Look at this Saravana: > 367dc4a cpufreq: Add stop CPU callback to cpufreq_driver interface >
I'll only get called at the same time as it is called today. __cpufreq_remove_dev_prepare is now renamed to __cpufreq_remove_dev. And this function is called from there.
The only time stop does get called is when __cpufreq_remove_dev is called on the last CPU of a policy. So, functionally it's identical.
Btw, I already added logs to all cpufreq driver ops and checked the calls come in the same order with and without my changes.
-Saravana
-- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
| |