Messages in this thread | | | Date | Tue, 15 Jul 2014 15:53:13 -0700 | From | josh@joshtrip ... | Subject | Re: [PATCH 2/3] rcu: Remove stale comment in tree.c |
| |
On Tue, Jul 15, 2014 at 06:31:48PM -0400, Pranith Kumar wrote: > This commit removes a stale comment in rcu/tree.c. > FYI, an updated comment exists a few lines below this. > > Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
In general, when removing a stale comment, I'd suggest explaining why the comment is stale. Was code removed without removing the corresponding comment, or was code changed such that the comment no longer applies, or...?
- Josh Triplett
> kernel/rcu/tree.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c > index a1abaa8..e67246e 100644 > --- a/kernel/rcu/tree.c > +++ b/kernel/rcu/tree.c > @@ -2211,8 +2211,6 @@ static void rcu_cleanup_dead_cpu(int cpu, struct rcu_state *rsp) > /* Adjust any no-longer-needed kthreads. */ > rcu_boost_kthread_setaffinity(rnp, -1); > > - /* Remove the dead CPU from the bitmasks in the rcu_node hierarchy. */ > - > /* Exclude any attempts to start a new grace period. */ > mutex_lock(&rsp->onoff_mutex); > raw_spin_lock_irqsave(&rsp->orphan_lock, flags); > -- > 1.9.1 >
| |