Messages in this thread | | | Date | Tue, 15 Jul 2014 15:58:46 +0900 | From | Jongsung Kim <> | Subject | Re: [PATCH 1/2] net: cadence: macb: add support for the WOL |
| |
On 07/14/2014 07:49 PM, David Laight wrote: > From: Varka Bhadram >> On 07/14/2014 02:32 PM, Jongsung Kim wrote: >>> This patch enables the ethtool utility to control the WOL function >>> of the PHY connected to the GEM/MACB. (if supported) > ... >>> +static int macb_set_wol(struct net_device *netdev, struct ethtool_wolinfo *wol) >>> +{ >>> + struct macb *bp = netdev_priv(netdev); >>> + struct phy_device *phydev = bp->phy_dev; >>> + int err = -ENODEV; >>> + >>> + if (phydev) >>> + err = phy_ethtool_set_wol(phydev, wol); >>> + >>> + return err; >>> +} >>> + >> >> I think we can do in this way: >> >> if (phydev) >> return phy_ethtool_set_wol(phydev, wol); >> else >> return -ENODEV; >> >> >> we can save err. What do you say ...? > > I would do: > if (!phydev) > return -ENODEV; > return phy_ethtool_set_wol(phydev, wol); > > Although it might even be worth moving the NULL test into the function. > (sort of depends on style and the number of callers who need to do the test.) >
Totally agreed. I'd be better to submit a patch about it first.
> David > > > >
| |