lkml.org 
[lkml]   [2014]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v2 24/29] nios2: Module support
    Date
    On Tuesday 15 July 2014 16:45:51 Ley Foon Tan wrote:
    > +void *module_alloc(unsigned long size)
    > +{
    > + if (size == 0)
    > + return NULL;
    > + return kmalloc(size, GFP_KERNEL);
    > +}
    > +
    > +/* Free memory returned from module_alloc */
    > +void module_free(struct module *mod, void *module_region)
    > +{
    > + kfree(module_region);
    > +}

    Any particular reason for defining these to use kmalloc rather than
    the default vmalloc based functions?

    Note that kmalloc is more limited in size and won't work if the memory
    is fragmented, while vmalloc has a small overhead on some architectures
    due to TLB pressure, but only if the normal kernel memory is able to
    use huge pages.

    > +void module_arch_cleanup(struct module *mod)
    > +{
    > +}

    This is not needed at all.

    Arnd


    \
     
     \ /
      Last update: 2014-07-15 13:01    [W:2.328 / U:1.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site