Messages in this thread | | | Date | Mon, 14 Jul 2014 20:02:43 -0300 | From | Henrique de Moraes Holschuh <> | Subject | Re: [PATCH] drivers/platform/x86/thinkpad_acpi.c: don't test unsigned int for negativity |
| |
On Tue, 15 Jul 2014, Andrey Utkin wrote: > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80231 > Reported-by: David Binderman <dcb314@hotmail.com> > Signed-off-by: Andrey Utkin <andrey.krieger.utkin@gmail.com>
Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
> --- > drivers/platform/x86/thinkpad_acpi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c > index d82f196..4d59b09 100644 > --- a/drivers/platform/x86/thinkpad_acpi.c > +++ b/drivers/platform/x86/thinkpad_acpi.c > @@ -6144,7 +6144,7 @@ static int brightness_set(unsigned int value) > { > int res; > > - if (value > bright_maxlvl || value < 0) > + if (value > bright_maxlvl) > return -EINVAL; > > vdbg_printk(TPACPI_DBG_BRGHT,
-- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh
| |