Messages in this thread | | | Date | Mon, 14 Jul 2014 10:20:52 -0700 | Subject | Re: [PATCH 4/4] xhci: Allow xHCI drivers to be built as separate modules | From | Andrew Bresticker <> |
| |
On Thu, Jul 10, 2014 at 11:34 AM, Julius Werner <jwerner@chromium.org> wrote: >> diff --git a/drivers/usb/host/Makefile b/drivers/usb/host/Makefile >> index af89a90..bafba71 100644 >> --- a/drivers/usb/host/Makefile >> +++ b/drivers/usb/host/Makefile >> @@ -15,19 +15,19 @@ fhci-$(CONFIG_FHCI_DEBUG) += fhci-dbg.o >> xhci-hcd-y := xhci.o xhci-mem.o >> xhci-hcd-y += xhci-ring.o xhci-hub.o xhci-dbg.o >> xhci-hcd-y += xhci-trace.o >> -xhci-hcd-$(CONFIG_PCI) += xhci-pci.o >> >> -ifneq ($(CONFIG_USB_XHCI_PLATFORM), ) >> - xhci-hcd-y += xhci-plat.o >> +xhci-plat-hcd-y := xhci-plat.o >> ifneq ($(CONFIG_USB_XHCI_MVEBU), ) >> - xhci-hcd-y += xhci-mvebu.o >> -endif > > nit: Can do this even simpler now, just > "xhci-plat-hcd-$(CONFIG_USB_XHCI_MVEBU) += xhci-mvebu.o" without the > ifneq.
Nope - since CONFIG_USB_XHCI_MVEBU can be 'y' or 'm' we need the ifneq here (which matches against both) to ensure xhci-mvebu.o is built is part of xhci-plat-hcd.o.
| |