lkml.org 
[lkml]   [2014]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] workqueue: remove the first check and the return value of maybe_create_worker()
On Fri, Jul 11, 2014 at 12:01:03AM +0800, Lai Jiangshan wrote:
> @@ -1887,17 +1887,11 @@ static void pool_mayday_timeout(unsigned long __pool)
> * spin_lock_irq(pool->lock) which may be released and regrabbed
> * multiple times. Does GFP_KERNEL allocations. Called only from
> * manager.
> - *
> - * Return:
> - * %false if no action was taken and pool->lock stayed locked, %true
> - * otherwise.
> */
> -static bool maybe_create_worker(struct worker_pool *pool)
> +static void maybe_create_worker(struct worker_pool *pool)

We probably should drop "maybe_" from the function name?

--
tejun


\
 
 \ /
  Last update: 2014-07-12 18:21    [W:0.573 / U:0.452 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site