lkml.org 
[lkml]   [2014]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 2/5] xen/pciback: Don't deadlock when unbinding.
> >--- a/drivers/xen/xen-pciback/pci_stub.c
> >+++ b/drivers/xen/xen-pciback/pci_stub.c
> >@@ -250,6 +250,8 @@ struct pci_dev *pcistub_get_pci_dev(struct xen_pcibk_device *pdev,
> > * - 'echo BDF > unbind' with a guest still using it. See pcistub_remove
> > *
> > * As such we have to be careful.
> >+ *
> >+ * To make this easier, the caller has to hold the device lock.
>
> Should we assert that the lock is being held?

Yes of course we should. Thank you!


\
 
 \ /
  Last update: 2014-07-11 23:41    [W:0.142 / U:0.888 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site