Messages in this thread | | | Date | Fri, 11 Jul 2014 12:40:24 +0200 | From | Sylwester Nawrocki <> | Subject | Re: [PATCH 2/2] clk: exynos-audss: Update as per existing framework |
| |
Hi Tushar,
On 11/07/14 11:37, Tushar Behera wrote: > Change exynos-audss clock driver as per existing clock framework from > the existing module driver framework.
Can you explain what's the actual issue you're trying to solve with that patch ? What's the problem with this driver being a platform driver ? It feels we're moving in circles here, see
commit b37a4224104568198b93fb9831224cfe7d83fff8 Author: Andrew Bresticker <abrestic@chromium.org> Date: Wed Sep 25 14:12:47 2013 -0700
clk: exynos-audss: convert to platform device
The Exynos AudioSS clock controller will later be modified to allow input clocks to be specified via device-tree in order to support multiple Exynos SoCs. This will introduce a dependency on the core SoC clock controller being initialized first so that the AudioSS driver can look up its input clocks, but the order in which clock providers are probed in of_clk_init() is not guaranteed. Since deferred probing is not supported in of_clk_init() and the AudioSS block is not the core controller, we can initialize it later as a platform device.
Signed-off-by: Andrew Bresticker <abrestic@chromium.org> Acked-by: Tomasz Figa <t.figa@samsung.com> Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com> Acked-by: Mike Turquette <mturquette@linaro.org> Acked-by: Kukjin Kim <kgene.kim@samsung.com> Signed-off-by: Tomasz Figa <t.figa@samsung.com>
I realize of_clk_init() now handles better clock provider dependencies, nevertheless do we really need all this churn ?
-- Thanks, Sylwester
| |