Messages in this thread | | | Date | Fri, 11 Jul 2014 10:41:18 +0100 | From | David Vrabel <> | Subject | Re: [PATCH 1/2 V2] PCI: introduce device assignment interface and refactory related code |
| |
On 11/07/14 06:52, Ethan Zhao wrote: > > --- a/drivers/xen/xen-pciback/pci_stub.c > +++ b/drivers/xen/xen-pciback/pci_stub.c > @@ -133,7 +133,7 @@ static void pcistub_device_release(struct kref *kref) > xen_pcibk_config_free_dyn_fields(dev); > xen_pcibk_config_free_dev(dev); > > - dev->dev_flags &= ~PCI_DEV_FLAGS_ASSIGNED; > + pci_sriov_deassign_device(dev); > pci_dev_put(dev); > > kfree(psdev); > @@ -404,7 +404,7 @@ static int pcistub_init_device(struct pci_dev *dev) > dev_dbg(&dev->dev, "reset device\n"); > xen_pcibk_reset_device(dev); > > - dev->dev_flags |= PCI_DEV_FLAGS_ASSIGNED; > + pci_sriov_assign_device(dev); > return 0;
Xen's PCI passthrough works with all PCI devices not just SR-IOV ones, so the naming of the helpers isn't correct.
David
| |