Messages in this thread Patch in this message | | | From | Joerg Roedel <> | Subject | [PATCH 5/9] iommu/amd: Drop pasid_state reference in ppr_notifer error path | Date | Thu, 10 Jul 2014 15:25:46 +0200 |
| |
From: Joerg Roedel <jroedel@suse.de>
In case we are not able to allocate a fault structure a reference to the pasid_state will be leaked. Fix that by dropping the reference in the error path in case we hold one.
Signed-off-by: Joerg Roedel <jroedel@suse.de> Tested-by: Oded Gabbay <Oded.Gabbay@amd.com> --- drivers/iommu/amd_iommu_v2.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/drivers/iommu/amd_iommu_v2.c b/drivers/iommu/amd_iommu_v2.c index 574c71b..6ba707b 100644 --- a/drivers/iommu/amd_iommu_v2.c +++ b/drivers/iommu/amd_iommu_v2.c @@ -607,6 +607,10 @@ static int ppr_notifier(struct notifier_block *nb, unsigned long e, void *data) ret = NOTIFY_OK; out_drop_state: + + if (ret != NOTIFY_OK && pasid_state) + put_pasid_state(pasid_state); + put_device_state(dev_state); out: -- 1.7.9.5
| |