Messages in this thread | | | Date | Thu, 10 Jul 2014 15:58:28 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH] ix86: fix vDSO build |
| |
On 07/03/2014 07:35 AM, Jan Beulich wrote: > Relying on static functions used just once to get inlined (and > subsequently have dead code paths eliminated) is wrong: Compilers are > free to decide whether they do this, regardless of optimization level. > With this not happening for vdso_addr() (observed with gcc 4.1.x), an > unresolved reference to align_vdso_addr() causes the build to fail.
The fix seems odd... more of the flavor of "happens to work" unless I'm misunderstanding something. If this needs to be inlined, wouldn't __always_inline make more sense?
What am I missing?
-hpa
| |