Messages in this thread Patch in this message | | | From | "Sharma, Sanjeev" <> | Subject | RE: [PATCH v3 4/4] staging: rtl8192u: Fixed too long lines | Date | Thu, 10 Jul 2014 12:18:42 +0000 |
| |
Hi Joe,
I have incorporated your review comment in version v4.
Regards Sanjeev Sharma
-----Original Message----- From: Joe Perches [mailto:joe@perches.com] Sent: Wednesday, July 09, 2014 6:27 PM To: sanjeev sharma Cc: gregkh@linuxfoundation.org; rmfrfs@gmail.com; peter.senna@gmail.com; teobaluta@gmail.com; devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org; Sharma, Sanjeev Subject: Re: [PATCH v3 4/4] staging: rtl8192u: Fixed too long lines
On Wed, 2014-07-09 at 17:49 +0530, sanjeev sharma wrote: > This patch will fix too long lines warning reported by checkpatch.pl.
Hi Sanjeev.
> diff --git a/drivers/staging/rtl8192u/r819xU_phy.c > b/drivers/staging/rtl8192u/r819xU_phy.c [] > @@ -1786,7 +1788,9 @@ void InitialGainOperateWorkItemCallBack(struct work_struct *work) > RT_TRACE(COMP_SCAN, "Scan BBInitialGainRestore 0xa0a is %x\n", > priv->initgain_backup.cca); > > - rtl8192_phy_setTxPower(dev, priv->ieee80211->current_network.channel); > + rtl8192_phy_setTxPower(dev, > + priv->ieee80211->current_network.channel > + );
This one is a little off
+ rtl8192_phy_setTxPower(dev, + priv->ieee80211->current_network.channel + );
Please align multiline statements to the appropriate open parenthesis using a mix of initial leading tabs followed by the minimal number of spaces required to put the first non-whitespace char at the column immediately after the preceding open paren.
Here it's 4 tabs, 7 spaces, not 5 tabs:
+ rtl8192_phy_setTxPower(dev, + priv->ieee80211->current_network.channel);
And please don't use a line that's just a close parenthesis and semicolon.
I think it's better to ignore the 80 column limit for these and place them at the end of the preceding line.
| |