Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH] GPIO button wth wakeup attribute is supposed to wake the system up | Date | Thu, 10 Jul 2014 13:27:02 +0200 |
| |
On Thursday, July 10, 2014 10:27:46 AM Li, Aubrey wrote: > On 2014/7/9 20:45, Rafael J. Wysocki wrote: > > On Tuesday, July 08, 2014 05:54:35 PM Dmitry Torokhov wrote: > >> On Wed, Jul 09, 2014 at 02:59:33AM +0200, Rafael J. Wysocki wrote: > >>> On Tuesday, July 08, 2014 05:15:06 PM Dmitry Torokhov wrote: > >>>> On Wed, Jul 09, 2014 at 01:06:07AM +0200, Rafael J. Wysocki wrote: > > > > [cut] > > > >>>> > >>>> When device driver marks IRQ as a wakeup source I believe it is prepared > >>>> to handle it (or it would shut it off explicitly). > >>> > >>> I can agree with that. > >>> > >>> Are you suggesting that __disable_irq() should check irq_data for > >>> IRQD_WAKEUP_STATE and skip the IRQ (in the 'suspend' case) if that is set? > >> > >> Yes, something like that. > > > > OK > > Many thanks to you both for the discussion. > > > > Aubrey, can you please check if the appended patch helps on the T100? > > I verified this patch on T100, it works as expected, freeze can be waken > up by reverting my patch and applying this one.
Thanks!
> Is this a final solution?
I hope so. I'll resend it with a proper changelog later today.
Rafael
| |