Messages in this thread | | | Subject | Re: [PATCH v2] perf: Handle compat ioctl | From | Pawel Moll <> | Date | Tue, 01 Jul 2014 17:06:00 +0100 |
| |
On Tue, 2014-06-17 at 13:43 +0100, Pawel Moll wrote: > When running a 32-bit userspace on a 64-bit kernel (eg. i386 > application on x86_64 kernel or 32-bit arm userspace on arm64 > kernel) some of the perf ioctls must be treated with special > care, as they have a pointer size encoded in the command. > > For example, PERF_EVENT_IOC_ID in 32-bit world will be encoded > as 0x80042407, but 64-bit kernel will expect 0x80082407. In > result the ioctl will fail returning -ENOTTY. > > This patch solves the problem by adding code fixing up the > size as compat_ioctl file operation. > > Reported-by: Drew Richardson <drew.richardson@arm.com> > Signed-off-by: Pawel Moll <pawel.moll@arm.com>
This just is a polite and friendly nag...
Any, strong or not, opinions on the matter?
Cheers!
Pawel
| |