Messages in this thread | | | Date | Mon, 9 Jun 2014 10:35:39 +0530 | Subject | Re: [PATCH v3] cpufreq: governor: Be friendly towards latency-sensitive bursty workloads | From | Viresh Kumar <> |
| |
On 8 June 2014 02:11, Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com> wrote: > diff --git a/drivers/cpufreq/cpufreq_governor.c b/drivers/cpufreq/cpufreq_governor.c
> + if (unlikely(wall_time > (2 * sampling_rate)) && > + j_cdbs->copy_prev_load) { > + load = j_cdbs->prev_load; > + j_cdbs->copy_prev_load = false; > + } else { > + load = 100 * (wall_time - idle_time) / wall_time; > + j_cdbs->prev_load = load; > + j_cdbs->copy_prev_load = true; > + }
Hmm, slight modifications over the weekend :) .. What do you think about removing this extra variable and using prev_load only, i.e. make it zero in the else part? Also adding a comment for this would be helpful ?
I will try a patch before you come to office :)
| |