lkml.org 
[lkml]   [2014]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 100/146] nfsd4: warn on finding lockowner without stateid's
    Date
    From: "J. Bruce Fields" <bfields@redhat.com>

    3.12-stable review patch. If anyone has any objections, please let me know.

    ===============

    commit 27b11428b7de097c42f205beabb1764f4365443b upstream.

    The current code assumes a one-to-one lockowner<->lock stateid
    correspondance.

    Signed-off-by: J. Bruce Fields <bfields@redhat.com>
    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    ---
    fs/nfsd/nfs4state.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
    index b21ed5e5b369..6f1250c14606 100644
    --- a/fs/nfsd/nfs4state.c
    +++ b/fs/nfsd/nfs4state.c
    @@ -4142,6 +4142,10 @@ static bool same_lockowner_ino(struct nfs4_lockowner *lo, struct inode *inode, c

    if (!same_owner_str(&lo->lo_owner, owner, clid))
    return false;
    + if (list_empty(&lo->lo_owner.so_stateids)) {
    + WARN_ON_ONCE(1);
    + return false;
    + }
    lst = list_first_entry(&lo->lo_owner.so_stateids,
    struct nfs4_ol_stateid, st_perstateowner);
    return lst->st_file->fi_inode == inode;
    --
    1.9.3


    \
     
     \ /
      Last update: 2014-06-09 11:41    [W:4.022 / U:0.260 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site