lkml.org 
[lkml]   [2014]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH] list: Fix order of arguments for hlist_add_after(_rcu)
    Date
    From: Behalf Of Ken Helias
    > All other add functions for lists have the new item as first argument and the
    > position where it is added as second argument. This was changed for no good
    > reason in this function and makes using it unnecessary confusing.
    >
    > Also the naming of the arguments in hlist_add_after was confusing. It was
    > changed to use the same names as hlist_add_after_rcu.
    ...
    > -static inline void hlist_add_after_rcu(struct hlist_node *prev,
    > - struct hlist_node *n)
    > +static inline void hlist_add_after_rcu(struct hlist_node *n,
    > + struct hlist_node *prev)

    It is rather a shame that the change doesn't generate a compilation
    error for old source files.

    David





    \
     
     \ /
      Last update: 2014-06-06 18:21    [W:3.216 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site