Messages in this thread | | | Date | Fri, 6 Jun 2014 11:10:42 +0200 | From | Michal Hocko <> | Subject | Re: [RFC][PATCH] oom: Be less verbose if the oom_control event fd has listeners |
| |
On Thu 05-06-14 14:01:02, David Rientjes wrote: > On Thu, 5 Jun 2014, Michal Hocko wrote: > > > If we are printing too much then OK, let's remove those parts which are > > not that useful but hiding information which tells us more about the oom > > decision doesn't sound right to me. > > > > Memcg oom killer printing is controlled mostly by > mem_cgroup_print_oom_info(), I don't see anything in the generic oom > killer that should be removed and that I have not used even for memcg ooms > in the past.
Yes, I find most of the information printed during OOM very helpful. After 58cf188ed649 (memcg, oom: provide more precise dump info while memcg oom happening) even memcg oom info is helpful.
> Perhaps there could be a case made for suppressing some of the > hierarchical stats from being printed for memcg ooms and controlled by > another memcg knob, but it doesn't sound vital.
Agreed.
-- Michal Hocko SUSE Labs
| |