Messages in this thread | | | Date | Thu, 5 Jun 2014 08:57:58 -0700 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 3.4 214/214] HID: logitech: dont use stack based dj_report structures |
| |
On Thu, Jun 05, 2014 at 08:12:08PM +0800, Yijing Wang wrote: > >> - dj_report.report_type = REPORT_TYPE_CMD_GET_PAIRED_DEVICES; > >> - return logi_dj_recv_send_report(djrcv_dev, &dj_report); > >> + dj_report = kzalloc(sizeof(dj_report), GFP_KERNEL); > > > > This patch was unfortunately incorrect as is - it needs to allocate > > sizeof(struct dj_report) here and a little further down. This was > > later fixed in mainline by 8a55ade7655, which should also be included > > if you take this - I don't see it in the current set. > > Good catch, I'm so sorry, I missed this fix patch. Marc, thanks for your review. > > Hi Greg, Can you cherry pick this fix patch? upstream commit id: 8a55ade7655(dj: memory scribble in logi_dj).
Now applied, thanks.
greg k-h
| |