Messages in this thread | | | Date | Thu, 05 Jun 2014 09:10:40 +0200 | From | Bart Van Assche <> | Subject | Re: [PATCH] scsi: bfa: bfad_attr.c: Optimization of the Code |
| |
On 06/05/14 08:55, Bart Van Assche wrote: > On 06/04/14 20:08, Rickard Strandqvist wrote: > This is ugly. Please use sprintf(buf, "%.*s\n", PAGE_SIZE - 1, str) > instead of strncpy() + strlen().
(replying to my own e-mail)
The above should of course have read "sprintf(buf, "%.*s\n", PAGE_SIZE - 2, str)" to avoid that the terminating '\0' triggers a buffer overflow.
Bart.
| |