lkml.org 
[lkml]   [2014]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.14 046/228] hwmon: (emc1403) fix inverted store_hyst()
    Date
    3.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Josef Gajdusek <atx@atx.name>

    commit 17c048fc4bd95efea208a1920f169547d8588f1f upstream.

    Attempts to set the hysteresis value to a temperature below the target
    limit fails with "write error: Numerical result out of range" due to
    an inverted comparison.

    Signed-off-by: Josef Gajdusek <atx@atx.name>
    Reviewed-by: Jean Delvare <jdelvare@suse.de>
    [Guenter Roeck: Updated headline and description]
    Signed-off-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/hwmon/emc1403.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/hwmon/emc1403.c
    +++ b/drivers/hwmon/emc1403.c
    @@ -163,7 +163,7 @@ static ssize_t store_hyst(struct device
    if (retval < 0)
    goto fail;

    - hyst = val - retval * 1000;
    + hyst = retval * 1000 - val;
    hyst = DIV_ROUND_CLOSEST(hyst, 1000);
    if (hyst < 0 || hyst > 255) {
    retval = -ERANGE;



    \
     
     \ /
      Last update: 2014-06-05 04:21    [W:5.471 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site