Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH v2 2/4] tools lib traceevent: Add options to plugins | Date | Tue, 03 Jun 2014 15:51:22 +0900 |
| |
On Mon, 02 Jun 2014 23:20:14 -0400, Steven Rostedt wrote: > +void traceevent_plugin_free_options_list(char **list) > +{ > + int i; > + > + if (!list) > + return; > + > + if (list == (char **)((unsigned long)-1))
It also should be:
if (list == INVALID_PLUGIN_LIST_OPTION)
Other than that, the series looks good to me now!
Thanks, Namhyung
> + return; > + > + for (i = 0; list[i]; i++) > + free(list[i]); > + > + free(list); > +}
| |