lkml.org 
[lkml]   [2014]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 2/4] tools lib traceevent: Add options to plugins
Date
On Mon, 02 Jun 2014 23:20:14 -0400, Steven Rostedt wrote:
> +void traceevent_plugin_free_options_list(char **list)
> +{
> + int i;
> +
> + if (!list)
> + return;
> +
> + if (list == (char **)((unsigned long)-1))

It also should be:

if (list == INVALID_PLUGIN_LIST_OPTION)


Other than that, the series looks good to me now!

Thanks,
Namhyung


> + return;
> +
> + for (i = 0; list[i]; i++)
> + free(list[i]);
> +
> + free(list);
> +}


\
 
 \ /
  Last update: 2014-06-03 09:41    [W:0.099 / U:2.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site