Messages in this thread | | | Date | Sun, 29 Jun 2014 12:45:41 +0200 | From | SF Markus Elfring <> | Subject | Re: [Cocci] [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions? |
| |
>> https://systeme.lip6.fr/pipermail/cocci/2014-March/000676.html >> http://marc.info/?l=kernel-janitors&m=139405971927100&w=2 > Regular expressions do not allow taking advantage of the optimizations > provided by Coccinelle and are not easy for a reader to understand.
I find that the application of regexes is appropriate here. Would you like to optimise any implementation details from my general approach?
>> https://systeme.lip6.fr/pipermail/cocci/2014-March/000677.html >> http://marc.info/?l=kernel-janitors&m=139405983727148&w=2 > This is not safe due to the use of when any. You have no guarantee that > there is not a dereference of input in the matched region, or that the > value of input is still the argument value at the point of the test.
Do you suggest to make the desired detection of input parameter validation a bit safer?
Regards, Markus
| |