Messages in this thread | | | Date | Fri, 27 Jun 2014 10:44:41 -0400 | From | Steven Rostedt <> | Subject | Re: [RFC][PATCH 3/5 v2] seq_buf: Move the seq_buf code to lib/ |
| |
On Fri, 27 Jun 2014 16:39:56 +0200 Petr Mládek <pmladek@suse.cz> wrote:
> > Nope, it just was copied by mistake. It only added dead code, it didn't > > move it. > > It is really missing! You removed kernel/trace/seq_buf.c and you have to > remove it also from kernel/trace/Makefile. :-)
OK, I see. Strange that this didn't complain when I compiled it :-/
Oh, I bet the .o file still existed. It would have complained if I did a make clean first. But then it should have complained about the dual definitions ??
-- Steve
> > Best Regards, > Petr > > > -- Steve > > > > > > > > diff --git a/kernel/trace/Makefile b/kernel/trace/Makefile > > > index edc98c72a634..67d6369ddf83 100644 > > > --- a/kernel/trace/Makefile > > > +++ b/kernel/trace/Makefile > > > @@ -29,7 +29,6 @@ obj-$(CONFIG_RING_BUFFER_BENCHMARK) += ring_buffer_benchmark.o > > > obj-$(CONFIG_TRACING) += trace.o > > > obj-$(CONFIG_TRACING) += trace_output.o > > > obj-$(CONFIG_TRACING) += trace_seq.o > > > -obj-$(CONFIG_TRACING) += seq_buf.o > > > obj-$(CONFIG_TRACING) += trace_stat.o > > > obj-$(CONFIG_TRACING) += trace_printk.o > > > obj-$(CONFIG_CONTEXT_SWITCH_TRACER) += trace_sched_switch.o > > > > > > > > > Best Regards, > > > Petr > >
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |