Messages in this thread Patch in this message | | | Subject | [PATCH V2] checkpatch: Add test for blank lines after function/struct/union/enum declarations | From | Joe Perches <> | Date | Wed, 25 Jun 2014 16:40:57 -0700 |
| |
Add a --strict test asking for a blank line after function/struct/union/enum declarations.
Allow exceptions for several attributes and macro uses.
Signed-off-by: Joe Perches <joe@perches.com> --- V2: Fix a problem with patch context lines by checking the line after the closing brace is an insertion.
scripts/checkpatch.pl | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 538105a..d56ad2a 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2291,6 +2291,22 @@ sub process { "networking block comments put the trailing */ on a separate line\n" . $herecurr); } +# check for missing blank lines after struct/union declarations +# with exceptions for various attributes and macros + if ($prevline =~ /^[\+ ]};?\s*$/ && + $line =~ /^\+/ && + !($line =~ /^\+\s*$/ || + $line =~ /^\+\s*EXPORT_SYMBOL/ || + $line =~ /^\+\s*MODULE_/i || + $line =~ /^\+\s*\#\s*(?:end|elif|else)/ || + $line =~ /^\+[a-z_]*init/ || + $line =~ /^\+\s*(?:static\s+)?[A-Z_]*ATTR/ || + $line =~ /^\+\s*DECLARE/ || + $line =~ /^\+\s*__setup/)) { + CHK("LINE_SPACING", + "Please use a blank line after function/struct/union/enum declarations\n" . $hereprev); + } + # check for missing blank lines after declarations if ($sline =~ /^\+\s+\S/ && #Not at char 1 # actual declarations
| |