Messages in this thread | | | From | Rasmus Villemoes <> | Subject | Re: [PATCH v2 0/4] lib: list_sort: Various minor improvements | Date | Thu, 26 Jun 2014 00:47:12 +0200 |
| |
Andrew Morton <akpm@linux-foundation.org> writes:
> On Thu, 26 Jun 2014 00:28:18 +0200 Rasmus Villemoes <linux@rasmusvillemoes.dk> wrote: > >> Minor comment: Won't this end up saying "list_sort_test: list passed to >> ...", despite the list coming from a 'real' user? Maybe change the first >> #define to '"list_sort: " fmt', the above message to "passed list too >> long for efficiency", and redefine pr_fmt right after #ifdef >> CONFIG_TEST_LIST_SORT. > > Yeah, I was hoping nobody would notice that ;) > > How about just > > printk_once(KERN_DEBUG "list too long for efficiency\n");
FWIW, fine by me.
Rasmus
| |