lkml.org 
[lkml]   [2014]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 0/4] lib: list_sort: Various minor improvements
Date
Andrew Morton <akpm@linux-foundation.org> writes:

> On Thu, 26 Jun 2014 00:28:18 +0200 Rasmus Villemoes <linux@rasmusvillemoes.dk> wrote:
>
>> Minor comment: Won't this end up saying "list_sort_test: list passed to
>> ...", despite the list coming from a 'real' user? Maybe change the first
>> #define to '"list_sort: " fmt', the above message to "passed list too
>> long for efficiency", and redefine pr_fmt right after #ifdef
>> CONFIG_TEST_LIST_SORT.
>
> Yeah, I was hoping nobody would notice that ;)
>
> How about just
>
> printk_once(KERN_DEBUG "list too long for efficiency\n");

FWIW, fine by me.

Rasmus


\
 
 \ /
  Last update: 2014-06-26 01:21    [W:0.044 / U:0.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site