Messages in this thread | | | Date | Wed, 25 Jun 2014 16:02:04 -0700 (PDT) | Subject | Re: [PATCH] cxgb4: use dev_port to identify ports | From | David Miller <> |
| |
From: Thadeu Lima de Souza Cascardo <cascardo@linux.vnet.ibm.com> Date: Mon, 23 Jun 2014 09:16:40 -0300
> On Sun, Jun 22, 2014 at 05:23:07PM -0700, David Miller wrote: >> From: Thadeu Lima de Souza Cascardo <cascardo@linux.vnet.ibm.com> >> Date: Sat, 21 Jun 2014 09:48:08 -0300 >> >> > Commit 3f85944fe207d0225ef21a2c0951d4946fc9a95d ("net: Add sysfs file >> > for port number") introduce dev_port to network devices. cxgb4 adapters >> > have multiple ports on the same PCI function, and used dev_id to >> > identify those ports. That use was removed by commit >> > 8c367fcbe6549195d2eb11e62bea233f811aad41 ("cxgb4: Do not set >> > net_device::dev_id to VI index"), since dev_id should be used only when >> > devices share the same MAC address. >> > >> > Using dev_port for cxgb4 allows different ports on the same PCI function >> > to be identified. >> > >> > Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@linux.vnet.ibm.com> >> >> You've made exactly zero effort to explain why the IPV6 issue carefully >> explained in commit 8c367fcbe6549195d2eb11e62bea233f811aad41 no longer >> applies. >> >> As far as I can tell, it absolutely does, and therefore this change >> here should not be made. >> >> I'm not applying this patch, sorry. >> > > I have set dev_port, not dev_id. This is not a revert of commit > 8c367fcbe6549195d2eb11e62bea233f811aad41. > > $ git grep dev_port net/ipv6/ > $ > > I believe dev_port was introduced exactly to solve the problem dev_id > was incorrectly being used for.
Aha, that makes much more sense. Thanks for explaining.
Applied, thanks.
| |