lkml.org 
[lkml]   [2014]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 01/22] pci-dma-compat: Add pci_zalloc_consistent helper
From
From: Joe Perches <joe@perches.com>
Date: Wed, 25 Jun 2014 14:51:51 -0700

> On Wed, 2014-06-25 at 12:27 -0700, Andrew Morton wrote:
>> On Mon, 23 Jun 2014 06:41:29 -0700 Joe Perches <joe@perches.com> wrote:
>>
>> > Add this helper for consistency with pci_zalloc_coherent
>> > and the ability to remove unnecessary memset(,0,) uses.
>>
>> While we're being anal.. I'm not a big fan of the patch titles. Worst
>> is "amd: Use pci_zalloc_consistent". "amd" is quite a poor identifier
>> - it's only when you get in and look at the diff that you realise it's
>> an ethernet driver.
>
> Yeah, those "amd:" prefixes should really have been "pcnet32:"
>
>> People sometimes address this by using
>>
>> "drivers: net: ethernet: amd: use pci_zalloc_consistent"
>>
>> which strikes me as utterly perverse. We already have a nice way of
>> representing the hierarchy and that's using '/'.
>
> I used to do that until several people complained.
> Now I don't. btw: Documentation/SubmittingPatches says:
>
> 15) The canonical patch format
>
> The canonical patch subject line is:
>
> Subject: [PATCH 001/123] subsystem: summary phrase

+1

We've been representing subsystems using colon prefixes for ages, and
I can't seen the value of starting to use something inconsistent with
a decade of precedence.


\
 
 \ /
  Last update: 2014-06-26 01:01    [W:0.074 / U:1.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site