Messages in this thread | | | Date | Wed, 25 Jun 2014 22:05:10 +0200 | From | "Luis R. Rodriguez" <> | Subject | Re: [PATCH 2/3] cxgb4: make configuration load use request_firmware_direct() |
| |
On Wed, Jun 25, 2014 at 11:58:52AM -0700, Casey Leedom wrote: > Okay, I'll leave the whole request_firmware{,_direct,_nowait}() thing > alone. The request_firmware_direct() will "solve" a non-problem (since all > of our "firmware" files are _supposed to be_ always present.
The code does not reflect that, it allows for files to not be present for the config stuff. If in practice files are always present that's a bit different.
> (And the 60 > second timeout for udev to confirm that a file doesn't exist seems like > udev is just basically broken.)
Its one reason it being tossed.
> That aside, we still need to solve the real problem that we're > experiencing in that the boot-time load of cxgb4 is timing out on SLE12 > because a maximum load timeout has been instituted in that distribution for > driver modules and if there are two 10Gb/s-BT adapters present in a system > which need both base firmware and BT PHY firmware, we exceed that timeout.
As for that it'd be great if you can answer some questions I had about the rest of firmware load processing on the other thread, I had a bit of questions for you there.
> The timeout really should be per device (since there ~could~ be an > arbitrary number of devices in a system) and there probably should be a way > for the driver to notify the kernel timeout mechanism that forward progress > is being made ...
I'd prefer we dive into this on the other thread.
Luis
| |