lkml.org 
[lkml]   [2014]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] scsi: bnx2i: bnx2i_iscsi.c: Cleaning up variable is set more than once
From
Date
On Wed, 2014-06-25 at 16:26 +0200, Maurizio Lombardi wrote:
> Hi,
>
> On 06/25/2014 04:04 PM, Rickard Strandqvist wrote:
> > A struct member variable is set to different values without having used in between.
> >
> > This was found using a static code analysis program called cppcheck
> >
> > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> > ---
> > drivers/scsi/bnx2i/bnx2i_iscsi.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c b/drivers/scsi/bnx2i/bnx2i_iscsi.c
> > index 166543f..fdf7bc3 100644
> > --- a/drivers/scsi/bnx2i/bnx2i_iscsi.c
> > +++ b/drivers/scsi/bnx2i/bnx2i_iscsi.c
> > @@ -1643,7 +1643,6 @@ static void bnx2i_conn_get_stats(struct iscsi_cls_conn *cls_conn,
> > stats->r2t_pdus = conn->r2t_pdus_cnt;
> > stats->tmfcmd_pdus = conn->tmfcmd_pdus_cnt;
> > stats->tmfrsp_pdus = conn->tmfrsp_pdus_cnt;
> > - stats->custom_length = 3;
> > strcpy(stats->custom[2].desc, "eh_abort_cnt");
> > stats->custom[2].value = conn->eh_abort_cnt;
> > stats->digest_err = 0;
> >
>
> Eddie,
>
> The code modifies the content of stats->custom[2], so shouldn't custom_length be set to 3?
> Why is it set to zero at the end of this function?
Nice find. This is literally a day1 bug. Yes, I agree that the
custom_length should be left at 3. Otherwise, the nlmsg replied back to
the application would not have the custom message. Thanks.
>
> Regards,
> Maurizio Lombardi




\
 
 \ /
  Last update: 2014-06-25 23:21    [W:0.056 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site