Messages in this thread | | | Date | Wed, 25 Jun 2014 14:15:32 -0600 | From | Shuah Khan <> | Subject | Re: [PATCH] tools: msgque improve error handling when not running as root |
| |
On 06/25/2014 02:05 PM, Davidlohr Bueso wrote: > On Wed, 2014-06-25 at 13:40 -0600, Shuah Khan wrote: >> The test fails in the middle when it is not run as root while >> accessing /proc/sys/kernel/msg_next_id. Changed it to check >> for root at the beginning of the test. Also added messages >> to indicate start and test pass status. >> >> Signed-off-by: Shuah Khan <shuah.kh@samsung.com> >> --- >> tools/testing/selftests/ipc/msgque.c | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/tools/testing/selftests/ipc/msgque.c b/tools/testing/selftests/ipc/msgque.c >> index aa290c0..30c627a 100644 >> --- a/tools/testing/selftests/ipc/msgque.c >> +++ b/tools/testing/selftests/ipc/msgque.c >> @@ -193,6 +193,12 @@ int main(int argc, char **argv) >> int msg, pid, err; >> struct msgque_data msgque; >> >> + if (getuid() != 0) { >> + fprintf(stderr, "Please run the test as root - Exiting.\n"); >> + exit(1); >> + } > > Please use err(3).
I will make this printf to be consistent with the rest of the printfs in this file.
> >> + printf("Starting ipc tests:\n"); > > This is unnecessary and adds nothing to the program.
The reason for doing this is it becomes easier to parse when this test is run as part of run_tests at the top level:
make -C tools/testing/selftests run_tests
-- Shuah
-- Shuah Khan Senior Linux Kernel Developer - Open Source Group Samsung Research America(Silicon Valley) shuah.kh@samsung.com | (970) 672-0658
| |