| Date | Wed, 25 Jun 2014 11:06:30 -0700 | Subject | Re: [PATCH v3 04/14] clk: max77686: Improve Maxim 77686 PMIC clocks binding | From | Doug Anderson <> |
| |
Javier,
On Thu, Jun 19, 2014 at 11:20 AM, Javier Martinez Canillas <javier.martinez@collabora.co.uk> wrote: > @@ -33,6 +38,6 @@ Example: Clock consumer node > foo@0 { > compatible = "bar,foo"; > /* ... */ > - clock-names = "my-clock"; > - clocks = <&max77686 2>; > + clock-names = "32khz_pmic"; > + clocks = <&max77686 MAX77686_CLK_PMIC>;
A minor comment here is that you probably shouldn't change "clock-names".
The "clock-names" is the consumer's concept of the clock name and not the producer's concept. If this clock were specified as going into the TPM, for instance, the TPM might call it "32k-reference". Then the TPM would get the clock by referring to this name in its driver.
-Doug
|