Messages in this thread | | | Date | Wed, 25 Jun 2014 10:56:34 -0400 | From | Tejun Heo <> | Subject | Re: [PATCH 1/6] percpu-refcount, aio: use percpu_ref_cancel_init() in ioctx_alloc() |
| |
Hello, Benjamin.
On Wed, Jun 25, 2014 at 10:31:12AM -0400, Benjamin LaHaise wrote: > On Tue, Jun 17, 2014 at 09:08:00PM -0400, Tejun Heo wrote: > > ioctx_alloc() reaches inside percpu_ref and directly frees > > ->pcpu_count in its failure path, which is quite gross. percpu_ref > > has been providing a proper interface to do this, > > percpu_ref_cancel_init(), for quite some time now. Let's use that > > instead. > > I applied this to my aio-next tree at git://git.kvack.org/~bcrl/aio-next.git .
It'd probably easier if I route this through percpu tree with the rest of changes as there are further changes on the aio side (trivial but still), so we'd end up having to do pulling dance back and forth. The changes on aio side are mostly trivial. Can I route them through percpu tree with your acks?
Thanks.
-- tejun
| |