Messages in this thread | | | Date | Wed, 25 Jun 2014 15:43:54 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH v8 4/9] sched: move no_new_privs into new atomic flags |
| |
On 06/24, Kees Cook wrote: > > --- a/include/linux/sched.h > +++ b/include/linux/sched.h > @@ -1307,8 +1307,7 @@ struct task_struct { > * execve */ > unsigned in_iowait:1; > > - /* task may not gain privileges */ > - unsigned no_new_privs:1; > + unsigned long atomic_flags; /* Flags needing atomic access. */ > > /* Revert to default priority/policy when forking */ > unsigned sched_reset_on_fork:1;
Agreed, personally I like it more than seccomp->flags.
But probably it would be better to place the new member before/after other bitfields to save the space?
Oleg.
| |