Messages in this thread | | | Date | Wed, 25 Jun 2014 10:26:56 -0400 | From | Paul Gortmaker <> | Subject | Re: [PATCH] scripts/mod/modpost.c: Fix bug in number_prefix |
| |
On 14-06-25 04:46 AM, Rasmus Villemoes wrote: > The function number_prefix() can currently only return 1 if its > argument is the empty string: If line 3 is reached and *sym (now the > second character in the argument) is not '.', 0 is returned. However, > if that character is '.', the first assignment to c is that same '.', > which obviously fails to be a digit.
I'd suggest you expand the commit log to actually list the end-user visible symptom and the use case that this actually fixes, since it isn't obvious to me at all.
Thanks, Paul. --
> > Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> > --- > scripts/mod/modpost.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c > index 9d9c5b9..336f45f 100644 > --- a/scripts/mod/modpost.c > +++ b/scripts/mod/modpost.c > @@ -778,9 +778,9 @@ static const char *sech_name(struct elf_info *elf, Elf_Shdr *sechdr) > */ > static int number_prefix(const char *sym) > { > - if (*sym++ == '\0') > + if (*sym == '\0') > return 1; > - if (*sym != '.') > + if (*sym++ != '.') > return 0; > do { > char c = *sym++; >
| |