Messages in this thread | | | Date | Wed, 25 Jun 2014 07:50:54 +0200 | From | Ingo Molnar <> | Subject | Re: [GIT PULL] liblockdep fixes for v3.15 |
| |
* Sasha Levin <sasha.levin@oracle.com> wrote:
> The following changes since commit 7171511eaec5bf23fb06078f59784a3a0626b38f: > > Linux 3.16-rc1 (2014-06-15 17:45:28 -1000) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux.git liblockdep-fixes > > for you to fetch changes up to b2f8bdb50a426aa104f7a57ca823589869b8da6f: > > tools/liblockdep: fix comparison of a boolean value with a value of 2 (2014-06-19 13:08:10 -0400) > > ---------------------------------------------------------------- > zhangdianfang (1): > tools/liblockdep: fix comparison of a boolean value with a value of 2 > > tools/lib/lockdep/preload.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
There's a couple of problems with the commit:
- Please capitalize the first word of the title, i.e.: "tools/liblockdep: Fix ..."
- Commit b2f8bdb is committed by you, but not signed off by you. I cannot pull SOB-less commits.
- It's not immediately obvious from the description why the change is made, please use the customary changelog style we use in the kernel:
" Current code does (A), this has a problem when (B). We can improve this doing (C), because (D)."
Thanks,
Ingo
| |