lkml.org 
[lkml]   [2014]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] sound: oss: mpu401.c: Cleaning up variable is set more than once
At Wed, 25 Jun 2014 14:18:24 +0200,
Rickard Strandqvist wrote:
>
> A struct member variable is set to the same value more than once
>
> This was found using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>

Applied, thanks.


Takashi

> ---
> sound/oss/mpu401.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/oss/mpu401.c b/sound/oss/mpu401.c
> index 3bbc3ec..31d7f72 100644
> --- a/sound/oss/mpu401.c
> +++ b/sound/oss/mpu401.c
> @@ -972,7 +972,6 @@ int attach_mpu401(struct address_info *hw_config, struct module *owner)
> devc->m_busy = 0;
> devc->m_state = ST_INIT;
> devc->shared_irq = hw_config->always_detect;
> - devc->irq = hw_config->irq;
> spin_lock_init(&devc->lock);
>
> if (devc->irq < 0)
> --
> 1.7.10.4
>


\
 
 \ /
  Last update: 2014-06-25 15:21    [W:0.050 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site