Messages in this thread | | | Date | Wed, 25 Jun 2014 10:06:05 +0200 | From | "Luis R. Rodriguez" <> | Subject | Re: [PATCH 3/3] p54: use request_firmware_direct() for optional EEPROM override |
| |
On Wed, Jun 25, 2014 at 09:26:23AM +0200, Arend van Spriel wrote: > On 25-06-14 00:39, Luis R. Rodriguez wrote: >> From: "Luis R. Rodriguez" <mcgrof@suse.com> >> >> The p54 driver uses request_firmware() twice, once for actual >> firmware and then another time for an optional user overide on >> EEPROM, 3826.eeprom. The custom EEPROM is optional but if not >> present we'll introduce an extra lag of 60 seconds with udev >> present. Annotate we don't want udev nonsense here to avoid >> the lag in case its not present. > > I guess the fact that EEPROM is optional does not matter much. If doing a > second request you could always use request_firmware_direct(), right?
The better way to rephrase this from a technical perspective is:
I don't care about udev firmware upload as it'll be removed, and its only adding 60 second delays. I *know* this driver doesn't require custom paths and wierd user upload tools so lets evolve a few light years ahead and embrace non-udev Direct upload for at least optional juju config data.
Luis
| |