Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH] tools: lib: traceevent: event-parse.c: Fix a risk for doing free on uninitialized pointer | Date | Wed, 25 Jun 2014 10:04:47 +0900 |
| |
Hi Rickard,
On Tue, 24 Jun 2014 13:09:10 +0200, Rickard Strandqvist wrote: > Fix a risk of doing free on an uninitialized pointer. > > This was found using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks, Namhyung
> --- > tools/lib/traceevent/event-parse.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c > index b83184f..857675e 100644 > --- a/tools/lib/traceevent/event-parse.c > +++ b/tools/lib/traceevent/event-parse.c > @@ -2390,7 +2390,7 @@ process_flags(struct event_format *event, struct print_arg *arg, char **tok) > { > struct print_arg *field; > enum event_type type; > - char *token; > + char *token = NULL; > > memset(arg, 0, sizeof(*arg)); > arg->type = PRINT_FLAGS; > @@ -2443,7 +2443,7 @@ process_symbols(struct event_format *event, struct print_arg *arg, char **tok) > { > struct print_arg *field; > enum event_type type; > - char *token; > + char *token = NULL; > > memset(arg, 0, sizeof(*arg)); > arg->type = PRINT_SYMBOL; > @@ -2482,7 +2482,7 @@ process_hex(struct event_format *event, struct print_arg *arg, char **tok) > { > struct print_arg *field; > enum event_type type; > - char *token; > + char *token = NULL; > > memset(arg, 0, sizeof(*arg)); > arg->type = PRINT_HEX;
| |