lkml.org 
[lkml]   [2014]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v8] NVMe: convert to blk-mq
On Tue, 24 Jun 2014, Matias Bjørling wrote:
> On Tue, Jun 24, 2014 at 10:33 PM, Keith Busch <keith.busch@intel.com> wrote:
>> On Tue, 24 Jun 2014, Matias Bjorling wrote:
>>> Den 16-06-2014 17:57, Keith Busch skrev:
>>>>
>>>> This latest is otherwise stable on my dev machine.
>>>
>>> May I add an Acked-by from you?
>>
>> Totally up to Willy, but my feeling is "not just yet". I see the value
>> this driver provides, but I would need to give this to a customer and
>> hear their results before adding an "ack". It maybe a couple more weeks
>> before they'll be able to try it.
>
> I was hoping to get an OK before that, to make sure it is picked up
> for the 3.17 release.
>
> Should I pack it up in a specific way to help it along?

I think what you're doing is the right way to go. I trust you removed
the test code from your next iteration, and this does pass my tests on my
machine... I was just hoping to hear what some other people with better
macro level benchmarking abilities would say. So okay, you can put my
"Acked-by" on this, but I don't have all the performance numbers yet.
\
 
 \ /
  Last update: 2014-06-25 00:21    [W:0.096 / U:0.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site