lkml.org 
[lkml]   [2014]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 04/13] mm, compaction: move pageblock checks up from isolate_migratepages_range()
On 06/24/2014 06:52 AM, Naoya Horiguchi wrote:
>> - low_pfn = isolate_migratepages_range(zone, cc, low_pfn, end_pfn, false);
>> - if (!low_pfn || cc->contended)
>> - return ISOLATE_ABORT;
>> + /* Do not scan within a memory hole */
>> + if (!pfn_valid(low_pfn))
>> + continue;
>> +
>> + page = pfn_to_page(low_pfn);
>
> Can we move (page_zone != zone) check here as isolate_freepages() does?

Duplicate perhaps, not sure about move. Does CMA make sure that all
pages are in the same zone? Common sense tells me it would be useless
otherwise, but I haven't checked if we can rely on it.

> Thanks,
> Naoya Horiguchi
>



\
 
 \ /
  Last update: 2014-06-24 18:21    [W:0.366 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site