lkml.org 
[lkml]   [2014]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] sched/idle: Drop !! while calculating 'broadcast'
From
Date
On Tue, 2014-06-24 at 10:03 +0200, Peter Zijlstra wrote: 
> On Tue, Jun 24, 2014 at 10:01:01AM +0530, Viresh Kumar wrote:
> > We don't need 'broadcast' to be set to 'zero or one', but to 'zero or non-zero'
> > and so the extra operation to convert it to 'zero or one' can be skipped.
> >
> > Also change type of 'broadcast' to unsigned int, i.e. type of
> > drv->states[*].flags.
>
> All true; but does it change anything? That is, does your compiler
> generate better code because of this?

x86_64 gcc-4.8.3 made 1 less instruction, a shift.

-Mike



\
 
 \ /
  Last update: 2014-06-24 15:41    [W:0.076 / U:0.856 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site