Messages in this thread | | | Subject | Re: [PATCH] sched/idle: Drop !! while calculating 'broadcast' | From | Mike Galbraith <> | Date | Tue, 24 Jun 2014 14:18:00 +0200 |
| |
On Tue, 2014-06-24 at 10:03 +0200, Peter Zijlstra wrote: > On Tue, Jun 24, 2014 at 10:01:01AM +0530, Viresh Kumar wrote: > > We don't need 'broadcast' to be set to 'zero or one', but to 'zero or non-zero' > > and so the extra operation to convert it to 'zero or one' can be skipped. > > > > Also change type of 'broadcast' to unsigned int, i.e. type of > > drv->states[*].flags. > > All true; but does it change anything? That is, does your compiler > generate better code because of this?
x86_64 gcc-4.8.3 made 1 less instruction, a shift.
-Mike
| |