lkml.org 
[lkml]   [2014]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/9] perf bench: Add --repeat option
Date
Hi Davidlohr,

On Thu, 19 Jun 2014 20:03:57 -0700, Davidlohr Bueso wrote:
> On Thu, 2014-06-19 at 23:51 +0000, Namhyung Kim wrote:
>> Hi Davidlohr,
>>
>> On Thu, Jun 19, 2014 at 11:45 AM, Davidlohr Bueso <davidlohr@hp.com> wrote:
>> > Hi Namhyung,
>> >
>> > On Thu, 2014-06-19 at 15:14 +0900, Namhyung Kim wrote:
>> >> By adding a top-level option, I think it should be applied to all
>> >> benchmaks - but I guess it only supports sched messaging and futex,
>> >> right?
>> >
>> > Yes, for now only those. While there is opportunity for others to use it
>> > as well (perhaps shed-pipe & memcpy/memset), I don't think *all*
>> > benchmarks need multiple runs, ie: numa.
>>
>> Hmm.. but it'd make users confusing if one runs the numa benchmark
>> with -r 5 option but it only do a single run..
>
> Yeah, it crossed my mind. For that to be addressed, we would have to
> come up with a way to determine if the argument was passed, and just
> inform the user that it is not [currently(?)] supported. Some
> alternatives would be to (i) explicitly document it, and/or (ii) print
> out the amount of runs that will be made and if that option is
> supported. All in all I think we need a better infrastructure for such
> things.

I think we don't need to prevent users if she really wants to run a
benchmark multiple times. So how about supporting it for all benchmarks
but providing sane per-benchmark defaults (i.e. 1 for numa, 5 for sched)?

Thanks,
Namhyung


\
 
 \ /
  Last update: 2014-06-24 08:41    [W:0.065 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site