| Date | Mon, 23 Jun 2014 14:19:25 -0700 | From | Andrew Morton <> | Subject | Re: [PATCHv2 1/6] mm/zbud: zbud_alloc() minor param change |
| |
On Mon, 2 Jun 2014 18:19:41 -0400 Dan Streetman <ddstreet@ieee.org> wrote:
> Change zbud to store gfp_t flags passed at pool creation to use for > each alloc; this allows the api to be closer to the existing zsmalloc > interface, and the only current zbud user (zswap) uses the same gfp > flags for all allocs. Update zswap to use changed interface.
This would appear to be a step backwards. There's nothing wrong with requiring all callers to pass in a gfp_t and removing this option makes the API less usable.
IMO the patch needs much better justification, or dropping.
|