Messages in this thread | | | Date | Mon, 23 Jun 2014 08:23:47 +0200 | Subject | Re: [RFC PATCH 0/3] Mark literal strings in __init / __exit code | From | Mathias Krause <> |
| |
On 23 June 2014 00:56, Joe Perches <joe@perches.com> wrote: > On Mon, 2014-06-23 at 00:46 +0200, Mathias Krause wrote: >> [...] patch 2 adds some syntactical sugar for the most popular use >> case, by providing pr_<level> alike macros, namely pi_<level> for __init >> code and pe_<level> for __exit code. This hides the use of the marker >> macros behind the commonly known printing functions -- with just a >> single character changed. >> >> Patch 3 exemplarily changes all strings and format strings in >> arch/x86/kernel/acpi/boot.c to use the new macros. It also addresses a >> few styling issues, though. But this already leads to ~1.7 kB of r/o >> data moved to the .init.rodata section, marking it for release after >> init. >> >> [...] > > I once proposed a similar thing. > > https://lkml.org/lkml/2009/7/21/421 > > Matt Mackall replied > > https://lkml.org/lkml/2009/7/21/463 >
Thanks for the pointers. Have you looked at patch 2 and 3? I don't think it makes the printk() case ugly. In fact, using pi_<level>() should be no less readable then pr_<level>, no?
Thanks, Mathias
| |