Messages in this thread Patch in this message | | | Date | Sat, 21 Jun 2014 13:37:52 -0700 | From | tip-bot for Thomas Gleixner <> | Subject | [tip:timers/core] tomoyo: Use sensible time interface |
| |
Commit-ID: 77f4fa089c724adc3a87c10eb031bca91b144ac0 Gitweb: http://git.kernel.org/tip/77f4fa089c724adc3a87c10eb031bca91b144ac0 Author: Thomas Gleixner <tglx@linutronix.de> AuthorDate: Wed, 11 Jun 2014 23:59:19 +0000 Committer: Thomas Gleixner <tglx@linutronix.de> CommitDate: Thu, 12 Jun 2014 16:18:45 +0200
tomoyo: Use sensible time interface
There is no point in calling gettimeofday if only the seconds part of the timespec is used. Use get_seconds() instead. It's not only the proper interface it's also faster.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Acked-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Cc: John Stultz <john.stultz@linaro.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Kentaro Takeda <takedakn@nttdata.co.jp> Cc: linux-security-module@vger.kernel.org Link: http://lkml.kernel.org/r/20140611234607.775273584@linutronix.de --- security/tomoyo/audit.c | 8 +++----- security/tomoyo/common.c | 4 +--- 2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/security/tomoyo/audit.c b/security/tomoyo/audit.c index c1b0037..3ffa4f5 100644 --- a/security/tomoyo/audit.c +++ b/security/tomoyo/audit.c @@ -155,11 +155,9 @@ static char *tomoyo_print_header(struct tomoyo_request_info *r) u8 i; if (!buffer) return NULL; - { - struct timeval tv; - do_gettimeofday(&tv); - tomoyo_convert_time(tv.tv_sec, &stamp); - } + + tomoyo_convert_time(get_seconds(), &stamp); + pos = snprintf(buffer, tomoyo_buffer_len - 1, "#%04u/%02u/%02u %02u:%02u:%02u# profile=%u mode=%s " "granted=%s (global-pid=%u) task={ pid=%u ppid=%u " diff --git a/security/tomoyo/common.c b/security/tomoyo/common.c index 283862a..e0fb750 100644 --- a/security/tomoyo/common.c +++ b/security/tomoyo/common.c @@ -2267,13 +2267,11 @@ static unsigned int tomoyo_stat_modified[TOMOYO_MAX_POLICY_STAT]; */ void tomoyo_update_stat(const u8 index) { - struct timeval tv; - do_gettimeofday(&tv); /* * I don't use atomic operations because race condition is not fatal. */ tomoyo_stat_updated[index]++; - tomoyo_stat_modified[index] = tv.tv_sec; + tomoyo_stat_modified[index] = get_seconds(); } /**
| |